[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 5/5] spapr_vscsi: convert to trace fr
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 5/5] spapr_vscsi: convert to trace framework instead of DPRINTF |
Date: |
Thu, 15 Sep 2016 10:09:59 +1000 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Wed, Sep 14, 2016 at 09:56:47PM +0200, Thomas Huth wrote:
> On 14.09.2016 20:48, Laurent Vivier wrote:
> > Signed-off-by: Laurent Vivier <address@hidden>
> > ---
> > hw/scsi/spapr_vscsi.c | 89
> > +++++++++++++++++++++------------------------------
> > hw/scsi/trace-events | 27 ++++++++++++++++
> > 2 files changed, 63 insertions(+), 53 deletions(-)
> >
> > diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c
> > index 8fbd50f..29fef90 100644
> > --- a/hw/scsi/spapr_vscsi.c
> > +++ b/hw/scsi/spapr_vscsi.c
>
> While you're at it: There is a stray fprintf statement at the beginning
> of vscsi_process_tsk_mgmt() which is rather a debug statement than
> really something that should be printed always ... could you please turn
> that into a trace event, too?
That would be a good idea, but I'd prefer to see it as a follow up patch.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-ppc] [PATCH 1/5] spapr_drc: convert to trace framework instead of DPRINTF, (continued)
- [Qemu-ppc] [PATCH 1/5] spapr_drc: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14
- [Qemu-ppc] [PATCH 2/5] spapr_rtas: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14
- [Qemu-ppc] [PATCH 3/5] spapr_vio: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14
- [Qemu-ppc] [PATCH 4/5] spapr_llan: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14
- [Qemu-ppc] [PATCH 5/5] spapr_vscsi: convert to trace framework instead of DPRINTF, Laurent Vivier, 2016/09/14
- Re: [Qemu-ppc] [PATCH 0/5] spapr: convert SPAPR devices to trace framework, David Gibson, 2016/09/14