[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 11/22] ppc/xics: remove the XICS list of ICS
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH v2 11/22] ppc/xics: remove the XICS list of ICS |
Date: |
Thu, 23 Feb 2017 13:33:28 +1100 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Thu, Feb 16, 2017 at 02:47:34PM +0100, Cédric Le Goater wrote:
> This is not used anymore.
>
> Signed-off-by: Cédric Le Goater <address@hidden>
Reviewed-by: David Gibson <address@hidden>
> ---
> hw/intc/xics.c | 8 --------
> hw/ppc/spapr.c | 1 -
> include/hw/ppc/xics.h | 2 --
> 3 files changed, 11 deletions(-)
>
> diff --git a/hw/intc/xics.c b/hw/intc/xics.c
> index d679313cd49f..5131587ce088 100644
> --- a/hw/intc/xics.c
> +++ b/hw/intc/xics.c
> @@ -146,13 +146,6 @@ static void xics_common_reset(DeviceState *d)
> }
> }
>
> -static void xics_common_initfn(Object *obj)
> -{
> - XICSState *xics = XICS_COMMON(obj);
> -
> - QLIST_INIT(&xics->ics);
> -}
> -
> static void xics_common_class_init(ObjectClass *oc, void *data)
> {
> DeviceClass *dc = DEVICE_CLASS(oc);
> @@ -165,7 +158,6 @@ static const TypeInfo xics_common_info = {
> .parent = TYPE_DEVICE,
> .instance_size = sizeof(XICSState),
> .class_size = sizeof(XICSStateClass),
> - .instance_init = xics_common_initfn,
> .class_init = xics_common_class_init,
> };
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index a2a64d7de41d..d1946ebcac69 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -122,7 +122,6 @@ static XICSState *try_create_xics(sPAPRMachineState
> *spapr,
> if (err) {
> goto error;
> }
> - QLIST_INSERT_HEAD(&xics->ics, spapr->ics, list);
>
> xics->ss = g_malloc0(nr_servers * sizeof(ICPState));
> xics->nr_servers = nr_servers;
> diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h
> index e10426e98e31..c15d8e2a8ae6 100644
> --- a/include/hw/ppc/xics.h
> +++ b/include/hw/ppc/xics.h
> @@ -82,7 +82,6 @@ struct XICSState {
> /*< public >*/
> uint32_t nr_servers;
> ICPState *ss;
> - QLIST_HEAD(, ICSState) ics;
> };
>
> #define TYPE_ICP "icp"
> @@ -152,7 +151,6 @@ struct ICSState {
> qemu_irq *qirqs;
> ICSIRQState *irqs;
> XICSState *xics;
> - QLIST_ENTRY(ICSState) list;
> };
>
> static inline bool ics_valid_irq(ICSState *ics, uint32_t nr)
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
[Qemu-ppc] [PATCH v2 09/22] ppc/xics: remove xics_find_source(), Cédric Le Goater, 2017/02/16
[Qemu-ppc] [PATCH v2 10/22] ppc/xics: register the reset handler of ICS objects, Cédric Le Goater, 2017/02/16
[Qemu-ppc] [PATCH v2 11/22] ppc/xics: remove the XICS list of ICS, Cédric Le Goater, 2017/02/16
- Re: [Qemu-ppc] [PATCH v2 11/22] ppc/xics: remove the XICS list of ICS,
David Gibson <=
[Qemu-ppc] [PATCH v2 12/22] ppc/xics: extend the QOM interface to handle ICPs, Cédric Le Goater, 2017/02/16
[Qemu-ppc] [PATCH v2 13/22] ppc/xics: simplify the cpu_setup() handler, Cédric Le Goater, 2017/02/16
[Qemu-ppc] [PATCH v2 14/22] ppc/xics: use the QOM interface to grab an ICP, Cédric Le Goater, 2017/02/16
[Qemu-ppc] [PATCH v2 15/22] ppc/xics: simplify spapr_dt_xics() interface, Cédric Le Goater, 2017/02/16
[Qemu-ppc] [PATCH v2 16/22] ppc/xics: register the reset handler of ICP objects, Cédric Le Goater, 2017/02/16