[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH] ohci: relax link check

From: BALATON Zoltan
Subject: Re: [Qemu-ppc] [PATCH] ohci: relax link check
Date: Tue, 7 Mar 2017 13:34:14 +0100 (CET)
User-agent: Alpine 2.20 (BSF 67 2015-01-07)

On Tue, 7 Mar 2017, Gerd Hoffmann wrote:
The strict td link limit added by commit "95ed569 usb: ohci: limit the
number of link eds" causes problems with macos guests.  Lets raise the

Reported-by: Programmingkid <address@hidden>
Reported-by: Howard Spoelstra <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>

Reviewed-by: BALATON Zoltan <address@hidden>

I've also tested that this fixes mouse under MorphOS as well. However I'm not sure that this limit is correct for every possible USB devices so this may need to be increased in the future if a device is found needing more linked TDs.

hw/usb/hcd-ohci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c
index fe8406a..3ada35e 100644
--- a/hw/usb/hcd-ohci.c
+++ b/hw/usb/hcd-ohci.c
@@ -42,7 +42,7 @@

#define OHCI_MAX_PORTS 15

-#define ED_LINK_LIMIT 4
+#define ED_LINK_LIMIT 32

static int64_t usb_frame_time;
static int64_t usb_bit_time;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]