[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 18/24] numa: remove no longer used numa_get_nod
From: |
Andrew Jones |
Subject: |
Re: [Qemu-ppc] [PATCH v2 18/24] numa: remove no longer used numa_get_node_for_cpu() |
Date: |
Thu, 4 May 2017 14:34:58 +0200 |
User-agent: |
Mutt/1.6.0.1 (2016-04-01) |
On Wed, May 03, 2017 at 02:57:12PM +0200, Igor Mammedov wrote:
> it's been replaced by fetching mapping info from possible_cpus
>
> Signed-off-by: Igor Mammedov <address@hidden>
> Reviewed-by: David Gibson <address@hidden>
> ---
> include/sysemu/numa.h | 4 ----
> numa.c | 14 --------------
> 2 files changed, 18 deletions(-)
>
> diff --git a/include/sysemu/numa.h b/include/sysemu/numa.h
> index 98d01e6..9077bb2 100644
> --- a/include/sysemu/numa.h
> +++ b/include/sysemu/numa.h
> @@ -32,10 +32,6 @@ void numa_set_mem_node_id(ram_addr_t addr, uint64_t size,
> uint32_t node);
> void numa_unset_mem_node_id(ram_addr_t addr, uint64_t size, uint32_t node);
> uint32_t numa_get_node(ram_addr_t addr, Error **errp);
>
> -/* on success returns node index in numa_info,
> - * on failure returns nb_numa_nodes */
> -int numa_get_node_for_cpu(int idx);
> -
> static inline bool numa_has_node_id(const CPUArchIdList *possible_cpus, int
> idx)
> {
> return possible_cpus->cpus[idx].props.has_node_id;
> diff --git a/numa.c b/numa.c
> index 872ee0d..06c42e9 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -583,20 +583,6 @@ MemdevList *qmp_query_memdev(Error **errp)
> return list;
> }
>
> -int numa_get_node_for_cpu(int idx)
> -{
> - int i;
> -
> - assert(idx < max_cpus);
> -
> - for (i = 0; i < nb_numa_nodes; i++) {
> - if (test_bit(idx, numa_info[i].node_cpu)) {
> - break;
> - }
> - }
> - return i;
> -}
> -
> void ram_block_notifier_add(RAMBlockNotifier *n)
> {
> QLIST_INSERT_HEAD(&ram_list.ramblock_notifiers, n, next);
> --
> 2.7.4
>
Reviewed-by: Andrew Jones <address@hidden>
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 12/24] numa: add numa_[has_]node_id() wrappers, (continued)
[Qemu-ppc] [PATCH v2 16/24] QMP: include CpuInstanceProperties into query_cpus output output, Igor Mammedov, 2017/05/03
[Qemu-ppc] [PATCH v2 17/24] tests: numa: add case for QMP command query-cpus, Igor Mammedov, 2017/05/03
[Qemu-ppc] [PATCH v2 18/24] numa: remove no longer used numa_get_node_for_cpu(), Igor Mammedov, 2017/05/03
- Re: [Qemu-ppc] [PATCH v2 18/24] numa: remove no longer used numa_get_node_for_cpu(),
Andrew Jones <=
[Qemu-ppc] [PATCH v2 20/24] machine: call machine init from wrapper, Igor Mammedov, 2017/05/03
[Qemu-ppc] [PATCH v2 19/24] numa: remove no longer need numa_post_machine_init(), Igor Mammedov, 2017/05/03
[Qemu-ppc] [PATCH v2 21/24] numa: use possible_cpus for not mapped CPUs check, Igor Mammedov, 2017/05/03
[Qemu-ppc] [PATCH v2 23/24] numa: add '-numa cpu, ...' option for property based node mapping, Igor Mammedov, 2017/05/03