[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH 2/6] spapr: fix error path of required kernel-irqchip
From: |
Greg Kurz |
Subject: |
[Qemu-ppc] [PATCH 2/6] spapr: fix error path of required kernel-irqchip |
Date: |
Mon, 15 May 2017 13:39:26 +0200 |
User-agent: |
StGit/0.17.1-20-gc0b1b-dirty |
QEMU should exit if the user explicitely asked for kernel-irqchip support
and "xics-kvm" initialization fails.
The changelog of commit 34f2af3d3edf ("spapr: Clean up misuse of qdev_init()
in xics-kvm creation") reads:
While there, improve the error message when we can't satisfy an
explicit user request for "xics-kvm", and exit(1) instead of abort().
Simplify the abort when we can't create "xics".
This patch adds the missing call to exit().
Signed-off-by: Greg Kurz <address@hidden>
---
hw/ppc/spapr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index abfb99b71b7d..f477d7b8a210 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -133,6 +133,7 @@ static void xics_system_init(MachineState *machine, int
nr_irqs, Error **errp)
if (machine_kernel_irqchip_required(machine) && !spapr->ics) {
error_reportf_err(err,
"kernel_irqchip requested but unavailable: ");
+ exit(EXIT_FAILURE);
} else {
error_free(err);
}
[Qemu-ppc] [PATCH 3/6] spapr: fix error reporting in xics_system_init(), Greg Kurz, 2017/05/15
[Qemu-ppc] [PATCH 4/6] spapr: sanitize error handling in spapr_ics_create(), Greg Kurz, 2017/05/15