[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v3 1/5] pnv_core: drop reference on ICPState objec
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH v3 1/5] pnv_core: drop reference on ICPState object during CPU realization |
Date: |
Thu, 8 Jun 2017 11:41:50 +1000 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Wed, Jun 07, 2017 at 07:49:14PM +0200, Cédric Le Goater wrote:
> On 06/07/2017 07:16 PM, Greg Kurz wrote:
> > Similarly to what was done to spapr with commit 249127d0dfeb, this patch
> > ensures that we don't keep an extra reference on the ICPState object. Also
> > since the object was just created and not reparented yet, the call to
> > object_property_add_child() should never fail: let's pass &error_abort to
> > make this clear.
> >
> > Signed-off-by: Greg Kurz <address@hidden>
>
> Reviewed-by: Cédric Le Goater <address@hidden>
Applied to ppc-for-2.10, thanks.
>
> Thanks,
>
> C.
>
> > ---
> > hw/ppc/pnv_core.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c
> > index 1b7ec70f033d..e8a9a94d5a24 100644
> > --- a/hw/ppc/pnv_core.c
> > +++ b/hw/ppc/pnv_core.c
> > @@ -119,7 +119,8 @@ static void pnv_core_realize_child(Object *child,
> > XICSFabric *xi, Error **errp)
> > Object *obj;
> >
> > obj = object_new(TYPE_PNV_ICP);
> > - object_property_add_child(OBJECT(cpu), "icp", obj, NULL);
> > + object_property_add_child(OBJECT(cpu), "icp", obj, &error_abort);
> > + object_unref(obj);
> > object_property_add_const_link(obj, "xics", OBJECT(xi), &error_abort);
> > object_property_set_bool(obj, true, "realized", &local_err);
> > if (local_err) {
> >
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-ppc] [PATCH v3 0/5] spapr/xics: fix migration of older machine types, Greg Kurz, 2017/06/07
- [Qemu-ppc] [PATCH v3 1/5] pnv_core: drop reference on ICPState object during CPU realization, Greg Kurz, 2017/06/07
- [Qemu-ppc] [PATCH v3 2/5] xics: add reset() handler to ICPStateClass, Greg Kurz, 2017/06/07
- [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, Greg Kurz, 2017/06/07
- Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, Cédric Le Goater, 2017/06/07
- Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, Greg Kurz, 2017/06/07
- Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, David Gibson, 2017/06/07
- Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, Greg Kurz, 2017/06/08
- Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, Cédric Le Goater, 2017/06/08
- Re: [Qemu-ppc] [PATCH v3 3/5] xics: setup cpu at realize time, Greg Kurz, 2017/06/08