[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v5 3/3] spapr: fix migration of ICPState objects f
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH v5 3/3] spapr: fix migration of ICPState objects from/to older QEMU |
Date: |
Wed, 14 Jun 2017 22:39:14 +0800 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Wed, Jun 14, 2017 at 03:29:19PM +0200, Greg Kurz wrote:
> Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under
> sPAPRCPUCore") moved ICPState objects from the machine to CPU cores.
> This is an improvement since we no longer allocate ICPState objects
> that will never be used. But it has the side-effect of breaking
> migration of older machine types from older QEMU versions.
>
> This patch allows spapr to register dummy "icp/server" entries to vmstate.
> These entries use a dedicated VMStateDescription that can swallow and
> discard state of an incoming migration stream, and that don't send anything
> on outgoing migration.
>
> As for real ICPState objects, the instance_id is the cpu_index of the
> corresponding vCPU, which happens to be equal to the generated instance_id
> of older machine types.
>
> The machine can unregister/register these entries when CPUs are dynamically
> plugged/unplugged.
>
> This is only available for pseries-2.9 and older machines, thanks to a
> compat property.
>
> Signed-off-by: Greg Kurz <address@hidden>
Applied to ppc-for-2.10.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-ppc] [PATCH v5 0/3] spapr/xics: fix migration of older machine types, Greg Kurz, 2017/06/14
- [Qemu-ppc] [PATCH v5 1/3] spapr: manage hotplugged devices while the VM is not started, Greg Kurz, 2017/06/14
- [Qemu-ppc] [PATCH v5 2/3] xics: directly register ICPState objects to vmstate, Greg Kurz, 2017/06/14
- [Qemu-ppc] [PATCH v5 3/3] spapr: fix migration of ICPState objects from/to older QEMU, Greg Kurz, 2017/06/14
- Re: [Qemu-ppc] [PATCH v5 3/3] spapr: fix migration of ICPState objects from/to older QEMU,
David Gibson <=
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v5 0/3] spapr/xics: fix migration of older machine types, no-reply, 2017/06/14
- Re: [Qemu-ppc] [PATCH v5 0/3] spapr/xics: fix migration of older machine types, David Gibson, 2017/06/14
- Re: [Qemu-ppc] [PATCH v5 0/3] spapr/xics: fix migration of older machine types, Cédric Le Goater, 2017/06/15