[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 0/6] spapr: DRC cleanups (part IV)
From: |
Alexey Kardashevskiy |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 0/6] spapr: DRC cleanups (part IV) |
Date: |
Fri, 16 Jun 2017 17:57:29 +1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 16/06/17 03:10, Laurent Vivier wrote:
> On 08/06/2017 07:09, David Gibson wrote:
>> This fourth isntallment of cleanups to the DRC code introduces the
>> first changes to the fundamental state handling. We change the
>> initial states in the reset code and attach code for PCI devices, and
>> are able to remove the 'signalled' state variable with those fixes.
>>
>> There are also some more mechanical cleanups in preparation for
>> further cleanups and fixes to the state management.
>>
>> David Gibson (6):
>> spapr: Start hotplugged PCI devices in ISOLATED state
>> spapr: Eliminate DRC 'signalled' state variable
>> spapr: Split DRC release from DRC detach
>> spapr: Make DRC reset force DRC into known state
>> spapr: Clean up DRC set_allocation_state path
>> spapr: Clean up DRC set_isolation_state() path
>>
>> hw/ppc/spapr.c | 15 --
>> hw/ppc/spapr_drc.c | 363
>> +++++++++++++++++++++++----------------------
>> hw/ppc/spapr_events.c | 10 --
>> include/hw/ppc/spapr_drc.h | 10 +-
>> 4 files changed, 188 insertions(+), 210 deletions(-)
>>
>
> I've tested your series rebased on master.
I have tested git://github.com/dgibson/qemu.git drcIV branch with 2xXHCI
multifunction PCI hotplug, works fine.
>
> - plugging a CPU while the OS is not started (stopped in SLOF/GRUB):
>
> The cpu can be hotplugged, but once the OS is started, the OS
> doesn't detect it and it can't be unplugged.
>
> - plugging a memory DIMM while the OS is not started:
>
> The first device_del does nothing, the second one crashes qemu
>
> - migration with hotplugged cpu (with OS started):
>
> CPU cannot be unplugged on destination side
>
> - migration with hotplugged memory DIMM (with OS started):
>
> The first device_del does nothing, the second one crashes qemu
>
> As it's cleanup, I guess this is what is expected
> (the results are the same as before cleanup series).
>
> Laurent
>
--
Alexey
- [Qemu-ppc] [PATCH 5/6] spapr: Clean up DRC set_allocation_state path, (continued)
- [Qemu-ppc] [PATCH 5/6] spapr: Clean up DRC set_allocation_state path, David Gibson, 2017/06/08
- [Qemu-ppc] [PATCH 1/6] spapr: Start hotplugged PCI devices in ISOLATED state, David Gibson, 2017/06/08
- [Qemu-ppc] [PATCH 6/6] spapr: Clean up DRC set_isolation_state() path, David Gibson, 2017/06/08
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 0/6] spapr: DRC cleanups (part IV), Laurent Vivier, 2017/06/15
- Re: [Qemu-ppc] [PATCH 0/6] spapr: DRC cleanups (part IV), Michael Roth, 2017/06/19
- Re: [Qemu-ppc] [PATCH 0/6] spapr: DRC cleanups (part IV), David Gibson, 2017/06/19