Re: [Qemu-ppc] [Qemu-devel] [PATCH] ppc: fix double-free in cpu_post_load()

[Philippe Mathieu-Daudé]

On 08/02/2017 02:34 PM, Greg Kurz wrote:
> When running nested with KVM PR, ppc_set_compat() fails and QEMU crashes
> because of "double free or corruption (!prev)". The crash happens because
> error_report_err() has already called error_free().
>
> Signed-off-by: Greg Kurz <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>   target/ppc/machine.c |    1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/target/ppc/machine.c b/target/ppc/machine.c
> index f578156dd411..abe0a1cdf021 100644
> --- a/target/ppc/machine.c
> +++ b/target/ppc/machine.c
> @@ -239,7 +239,6 @@ static int cpu_post_load(void *opaque, int version_id)
>           ppc_set_compat(cpu, cpu->compat_pvr, &local_err);
>           if (local_err) {
>               error_report_err(local_err);
> -            error_free(local_err);
>               return -1;
>           }
>       } else