[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] hw/ppc/spapr: Fix segfault when instantiating a '
Re: [Qemu-ppc] [PATCH] hw/ppc/spapr: Fix segfault when instantiating a 'pc-dimm' without 'memdev'
Mon, 21 Aug 2017 15:27:39 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1
On 21/08/2017 12:35, David Gibson wrote:
> From: Thomas Huth <address@hidden>
> QEMU currently crashes when trying to use a 'pc-dimm' on the pseries
> machine without specifying its 'memdev' property. This happens because
> pc_dimm_get_memory_region() does not check whether the 'memdev' property
> has properly been set by the user. Looking closer at this function, it's
> also obvious that it is using &error_abort to call another function - and
> this is bad in a function that is used in the hot-plugging calling chain
> since this can also cause QEMU to exit unexpectedly.
> So let's fix these issues in a proper way now: Add a "Error **errp"
> parameter to pc_dimm_get_memory_region() which we use in case the 'memdev'
> property has not been set by the user, and which we can use instead of
> the &error_abort, and change the callers of get_memory_region() to make
> use of this "errp" parameter for proper error checking.
> Signed-off-by: Thomas Huth <address@hidden>
> Reviewed-by: Igor Mammedov <address@hidden>
> Signed-off-by: David Gibson <address@hidden>
> hw/i386/pc.c | 14 ++++++++++++--
> hw/mem/nvdimm.c | 2 +-
> hw/mem/pc-dimm.c | 14 +++++++++++---
> hw/ppc/spapr.c | 42 ++++++++++++++++++++++++++++++------------
> include/hw/mem/pc-dimm.h | 2 +-
> 5 files changed, 55 insertions(+), 19 deletions(-)
Reviewed-by: Laurent Vivier <address@hidden>