qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH v2 9/8] fixup! ppc: remove non implemented cpu mod


From: Thomas Huth
Subject: Re: [Qemu-ppc] [PATCH v2 9/8] fixup! ppc: remove non implemented cpu models
Date: Wed, 30 Aug 2017 16:44:53 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 30.08.2017 16:26, Igor Mammedov wrote:
> only TODO escaped defines were meant to be removed,
> but not TODO_USER_ONLY which are compiled in case of
> *-user targets.
> 
> So retirn back "440" model removed by mistake
> 
> Spotted-by: Thomas Huth <address@hidden>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
>  target/ppc/cpu-models.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c
> index 611fc1b..08fb34b 100644
> --- a/target/ppc/cpu-models.c
> +++ b/target/ppc/cpu-models.c
> @@ -150,6 +150,10 @@
>      POWERPC_DEF("x2vp20",        CPU_POWERPC_X2VP20,                 405,
>                  NULL)
>      /* PowerPC 440 family                                                    
> */
> +#if defined(TODO_USER_ONLY)
> +    POWERPC_DEF("440",           CPU_POWERPC_440,                    440GP,
> +                "Generic PowerPC 440")
> +#endif
>      /* PowerPC 440 cores                                                     
> */
>      POWERPC_DEF("440-xilinx",    CPU_POWERPC_440_XILINX,             440x5,
>                  "PowerPC 440 Xilinx 5")
> 

With this fixup patch added:

Reviewed-by: Thomas Huth <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]