qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH v2 2/3] hmp: fix "dump-quest-memory" segfault (arm


From: Laurent Vivier
Subject: Re: [Qemu-ppc] [PATCH v2 2/3] hmp: fix "dump-quest-memory" segfault (arm)
Date: Mon, 11 Sep 2017 17:35:34 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 11/09/2017 16:39, Peter Maydell wrote:
> On 11 September 2017 at 15:20, Laurent Vivier <address@hidden> wrote:
>> Commit fd5d23babf (hmp: fix "dump-quest-memory" segfault)
>> fixes the problem for i386, do the same for arm.
>>
>> Running QEMU with
>>     qemu-system-aarch64 -M none -nographic -m 256
>> and executing
>>     dump-guest-memory /dev/null 0 8192
>> results in segfault
>>
>> Fix by checking if we have CPU.
>>
>> Signed-off-by: Laurent Vivier <address@hidden>
> 
> It seems a little arbitrary to assume that if there's no
> CPU what you wanted was a 32-bit little-endian dump.

We need a default value.  Is 64bit and/or big-endian better?

> Why do we have a machine without a CPU anyway ?

To hotplug it later?

As we can, we should avoid the segfault.

Thanks,
Laurent



reply via email to

[Prev in Thread] Current Thread [Next in Thread]