Re: [Qemu-ppc] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc)

[Cornelia Huck]

On Wed, 13 Sep 2017 13:44:57 +0100
"Dr. David Alan Gilbert" <address@hidden> wrote:

> * David Gibson (address@hidden) wrote:
> > On Tue, Sep 12, 2017 at 04:01:47PM +0200, Laurent Vivier wrote:  
> > > Running QEMU with
> > >     qemu-system-ppc64 -M none -nographic -m 256
> > > and executing
> > >     dump-guest-memory /dev/null 0 8192
> > > results in segfault
> > > 
> > > Fix by checking if we have CPU, and exit with
> > > error if there is no CPU:
> > > 
> > >     (qemu) dump-guest-memory /dev/null
> > >     this feature or command is not currently supported
> > > 
> > > Signed-off-by: Laurent Vivier <address@hidden>  
> > 
> > Applied to ppc-for-2.11.  I'm not really sure what to do with the rest
> > of the series though.  
> 
> I can take the whole set through HMP.

If you do so, you should probably take "dump: do not dump non-existent
guest memory" as well.