[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 12/25] spapr: introduce a XIVE interrupt presenter

From: Cédric Le Goater
Subject: Re: [Qemu-ppc] [PATCH 12/25] spapr: introduce a XIVE interrupt presenter model
Date: Fri, 1 Dec 2017 09:02:07 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0

>>> That'd be ok.  Or call if sPAPRIVPE.  Or even call it TIMA.  I'd be
>>> fine with any of those.
>> In this model, I am making a lot of shortcuts in the XIVE concepts
>> (which I don't master completely yet ...) 
>> The IVPE is the part of the overall controller doing the interrupt 
>> presentation.
>> The TIMA refers to the MMIO region in which the thread interrupt 
>> management is done. 
>> The XIVE structure that contains the 'virtual processor' interrupt 
>> state is the NVT: Notification Virtual Target. An index to an NVT 
>> is stored in the EQs to do the routing. I did not introduce the NVT 
>> in sPAPRXive because it's rather big, 128 bytes, and we don't need 
>> much of it (NSR, CPPR, PIPR, IPB) but we could use a shorten one.
>> So I think sPAPRXiveNVT, or sPAPRXiveVP (VP for virtual processor)
>> would be better names.
> Ok.  I prefer sPAPRXiveNVT of these two.

Fine. Also what about the location of the files. They are under
hw/intc/ but shouldn't we consider moving them under hw/spapr/ ? 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]