[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [RFC for-2.12 5/8] spapr: Assume msi_nonbroken
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [RFC for-2.12 5/8] spapr: Assume msi_nonbroken |
Date: |
Mon, 11 Dec 2017 20:40:21 +1100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Mon, Dec 11, 2017 at 07:19:53PM +1100, Alexey Kardashevskiy wrote:
> On 11/12/17 18:08, David Gibson wrote:
> > We conditionally adjust part of the guest device tree based on the
> > global msi_nonbroken flag. However, the main machine type code
> > initializes msi_nonbroken to true and there's nothing that would set
> > it to false again.
> >
> > So replace the test with an assert().
>
> Reviewed-by: Alexey Kardashevskiy <address@hidden>
>
> This does not really belong to the series.
True. I've moved it into the main ppc-for-2.12.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [Qemu-ppc] [RFC for-2.12 2/8] spapr: Capabilities infrastructure, (continued)
[Qemu-ppc] [RFC for-2.12 1/8] spapr: Rename machine init functions for clarity, David Gibson, 2017/12/11
[Qemu-ppc] [RFC for-2.12 5/8] spapr: Assume msi_nonbroken, David Gibson, 2017/12/11
[Qemu-ppc] [RFC for-2.12 7/8] spapr: Handle VMX/VSX presence as an spapr capability flag, David Gibson, 2017/12/11
[Qemu-ppc] [RFC for-2.12 6/8] target/ppc: Clean up probing of VMX, VSX and DFP availability on KVM, David Gibson, 2017/12/11
[Qemu-ppc] [RFC for-2.12 4/8] spapr: Validate capabilities on migration, David Gibson, 2017/12/11