Re: [Qemu-ppc] [PATCH 4/4] tests/pxe-test: Add some extra tests

[Thomas Huth]

On 15.12.2017 11:16, David Gibson wrote:
> Previously virtio-net was only tested for ppc64 in "slow" mode.  That
> doesn't make much sense since virtio-net is used much more often in
> practice than the spapr-vlan device which was tested always.  So, move
> virtio-net to always be tested on ppc64.

Actually, I just moved virtio-net on ppc64 to the slow category a couple
of months ago:

https://git.qemu.org/?p=qemu.git;a=commitdiff;h=ab06ec43577177a442e8e5

This has been done since some people complained that SLOF is incredibly
slow in in TCG mode and thus there is the risk of hitting the timeout on
slow systems if they are overloaded.

Things will hopefully get a little bit better with the "Use
tcg_gen_lookup_and_goto_ptr" patch that you've queued in your
ppc-for-2.12 branch, but still, the test is very slow on ppc64, so I'd
rather keep it in the "slow" category. (virtio-net is already tested in
big endian mode on s390x anyway, so we at least got some endianess test
coverage for that NIC already).

> We had no tests at all for the q35 machine, which doesn't seem wise given
> it's increasing prominence.  Add a couple of tests for it, including
> testing the newer e1000e adapter.

That sounds like a good idea! I wonder whether we should also test some
"old" machine versions (in "slow" mode only, of course), like "pc-0.12"
for example, to make sure that there are no regressions with old machines?

 Thomas