[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 0/2] Clean up the ppc default configs

From: BALATON Zoltan
Subject: Re: [Qemu-ppc] [PATCH 0/2] Clean up the ppc default configs
Date: Mon, 15 Jan 2018 13:00:35 +0100 (CET)
User-agent: Alpine 2.21 (BSF 202 2017-01-01)

On Mon, 15 Jan 2018, Thomas Huth wrote:
ppc64-softmmu is a superset of ppc-softmmu which in turn is a superset
of ppcemb-softmmu. But since the config files are currently independent
from each other, we missed to define some CONFIG switches in the super-
sets: CONFIG_SUNGEM is missing from the ppc64-softmmu config, and the
CONFIG_IDE_SII3112 switch is only defined in ppcemb-softmmu.

I'm not sure about this. The Sun GEM network interface is a device typically found on Apple PowerMacs but also seems to be found on G5 based Macs so it's probably OK to add. The SiI3112 is now only used on the (not yet fully merged) Sam460EX emulation which is to be added to ppcemb, that's why I've only added it to that target. Defining it on other targets does no harm (other than making the binary bigger) just maybe not necessary. If you think this makes the configs simpler I'm OK with this change just note that it probably makes it impossible to add options only for ppcemb without also adding them to ppc and ppc64. If that's OK then go ahead.

(off-topic question: Do we still need a separate ppcemb-softmmu nowadays?
It seemed to be useful 10 years ago when everybody was doing KVM on
embedded PPC, but these days seem to be pretty much over now, so IMHO
just using ppc-softmmu for embedded should be enough nowadays? We could
save quite some compilation- and "make check"-time if we could finally get
rid of ppcemb-softmmu again...)

I've also noticed that most of the boards were available both in ppcemb and ppc targets so maybe these could be merged now to avoid confusion but I don't know the reason why ppcemb existed in the first place so I don't know what other implications dropping ppcemb may have.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]