Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 1/7] accel/tcg: add size paremeter in tlb_fill()

[Richard Henderson]

On 01/12/2018 04:43 PM, Laurent Vivier wrote:
> The MC68040 MMU provides the size of the access that
> triggers the page fault.
> 
> This size is set in the Special Status Word which
> is written in the stack frame of the access fault
> exception.
> 
> So we need the size in m68k_cpu_unassigned_access() and
> m68k_cpu_handle_mmu_fault().
> 
> To be able to do that, this patch modifies the prototype of
> handle_mmu_fault handler, tlb_fill() and probe_write().
> do_unassigned_access() already includes a size parameter.
> 
> This patch also updates handle_mmu_fault handlers and
> tlb_fill() of all targets (only parameter, no code change).
> 
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
> v2: use "0" for the access size when we don't know
>     the size of the access
>     

Reviewed-by: Richard Henderson <address@hidden>


r~