[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PULL 06/11] hw/ide: Emulate SiI3112 SATA controller

From: Peter Maydell
Subject: Re: [Qemu-ppc] [PULL 06/11] hw/ide: Emulate SiI3112 SATA controller
Date: Thu, 18 Jan 2018 12:10:09 +0000

On 11 January 2018 at 04:59, David Gibson <address@hidden> wrote:
> From: BALATON Zoltan <address@hidden>
> This is a common generic PCI SATA controller that is also used in PCs
> but more importantly guests running on the Sam460ex board prefer this
> card and have a driver for it (unlike for other SATA controllers
> already emulated).
> Signed-off-by: BALATON Zoltan <address@hidden>
> Acked-by: John Snow <address@hidden>
> Signed-off-by: David Gibson <address@hidden>

> +    case 0x1c8:
> +        val = d->regs[1].sien << 16;
> +        break;

There's a similar unintended-sign-extension issue here (CID 1385145);
again, a cast should fix.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]