[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH v2] ppc440_pcix: Change some error_re

From: Peter Maydell
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH v2] ppc440_pcix: Change some error_report to qemu_log_mask(LOG_UNIMP, ...)
Date: Fri, 9 Mar 2018 10:39:37 +0000

On 9 March 2018 at 03:05, David Gibson <address@hidden> wrote:
> On Fri, Mar 09, 2018 at 10:44:46AM +1100, David Gibson wrote:
>> On Thu, Mar 08, 2018 at 12:08:08PM +0100, BALATON Zoltan wrote:
>> > Using log unimp is more appropriate for these messages and this also
>> > silences them by default so they won't clobber make check output when
>> > tests are added for this board.
>> >
>> > Signed-off-by: BALATON Zoltan <address@hidden>
>> > Reviewed-by: Thomas Huth <address@hidden>
>> Applied, thanks.
> Wait.. I've taken it out again.  Under some configurations (exercised
> by Travis) qemu_log_mask() is undeclared here you're using it.  See
> https://travis-ci.org/dgibson/qemu/jobs/351093986 for some more
> information.

Ah, that one again. There's a patch in Stefan's tracing tree
that makes that a fails-everywhere rather than only-some-configs,
but he hasn't done the pullreq for 2.12 yet I think.

You need a #include "qemu/log.h".

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]