[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH] qemu: include generated files with <> and not ""

From: Thomas Huth
Subject: Re: [Qemu-ppc] [PATCH] qemu: include generated files with <> and not ""
Date: Tue, 20 Mar 2018 14:46:46 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 20.03.2018 14:32, Gerd Hoffmann wrote:
>   Hi,
>>> So for these, we should use "".  None of these are generated files though.
>> That leads to crazy inconsistent message for developers where 50% of QEMU
>> header files must use <> and the other 50% of header files must use "".
> The rules are pretty simple though:
>    (1) Headers which are generated use <>.
>    (2) Headers which are in include/ use <>.
>    (3) Headers sitting in the same directory as the source files use "".

Ugh, no. Please don't. The normal way of including header files in QEMU
is to use "" - also for headers that are not in the same directory. For
example just do a

 grep -r '^#include.*hw/' hw/

from the top directory and you'll see what I mean. Changing that rule is
crazy. So please, let's just fix the configure script to detect some
more stale files in the source tree, and we're done.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]