[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 4/4] Remove unnecessary variables for function ret

From: Peter Maydell
Subject: Re: [Qemu-ppc] [PATCH 4/4] Remove unnecessary variables for function return value
Date: Thu, 22 Mar 2018 17:23:21 +0000

On 22 March 2018 at 17:19, Max Filippov <address@hidden> wrote:
> Ok, I can add a fixup that changes #include <xtensa-isa.h> to #include
> "xtensa-isa.h".
> Adding #include "qemu/osdep.h" there seems pointless to me.

Every top level .c file must start with including osdep.h.
Other headers that it might include rely on that.
It looks like these files aren't actually top level .c files,
but are only compiled by being #included from some other file.
Our convention for that kind of thing is to give the file
a .inc.c extension. If you follow that then clean-includes
will skip the file rather than trying to apply the requirements
for a top level .c file to it.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]