[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 4/4] Remove unnecessary variables for function ret

From: Eric Blake
Subject: Re: [Qemu-ppc] [PATCH 4/4] Remove unnecessary variables for function return value
Date: Thu, 22 Mar 2018 12:30:17 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/22/2018 12:19 PM, Max Filippov wrote:

These files were autogenerated, fixing them doesn't make much sense.

Good to know. They have been already updated by a couple of patches:

8f0a3716e4 Clean up includes
d8e39b7062 Use #include "..." for our own headers, <...> for others

Perhaps import_core.sh can be updated?

Ok, I can add a fixup that changes #include <xtensa-isa.h> to #include
Adding #include "qemu/osdep.h" there seems pointless to me.

Or we can add more exceptions to our tooling to recognize the files as generated. The scripts/clean-includes script knows to leave certain files alone, so add your files to that list.

I'm less certain of whether our Coccinelle scripts have easy ways to exclude specific files. We already have scripts/cocci-macro-file.h to help Coccinelle not choke on some our existing files, but I'm not sure if Coccinelle has a config-file like way that is easy to maintain as a data file in-tree for blacklist files to leave alone (right now, when I run Coccinelle, I have to manually remember to pass a long command line cribbed out of the commit message of an earlier run to pick up things like cocci-macro-file.h, instead of an easy formula that points to a single config file to pull in all the usual options).

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]