[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH 0/4] coccinelle: re-run scripts from

From: Peter Maydell
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 0/4] coccinelle: re-run scripts from scripts/coccinelle
Date: Thu, 22 Mar 2018 18:00:28 +0000

On 22 March 2018 at 17:57,  <address@hidden> wrote:
> Checking PATCH 4/4: Remove unnecessary variables for function return value...
> ERROR: return is not a function, parentheses are not required
> #251: FILE: target/mips/dsp_helper.c:3281:
> +    return (temp[1] << 63) | (temp[0] >> 1);

This looks like a bug in checkpatch. I guess to fix it you'd need
to make checkpatch count opening and closing parens in the line
to see if it goes to 0 somewhere other than just before the ';'...

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]