[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH for-2.13 v2 2/5] ppc: e500: switch E500 based mach
Re: [Qemu-ppc] [PATCH for-2.13 v2 2/5] ppc: e500: switch E500 based machines to full machine definition
Thu, 19 Apr 2018 10:30:19 +0200
On Thu, 19 Apr 2018 14:15:20 +1000
David Gibson <address@hidden> wrote:
> On Wed, Apr 18, 2018 at 04:28:02PM +0200, Igor Mammedov wrote:
> > Convert PPCE500Params to PCCE500MachineClass which it essentially is,
> > and introduce PCCE500MachineState to keep track of E500 specific
> > state instead of adding global variables or extra parameters to
> > functions when we need to keep data beyond machine init
> > (i.e. make it look like typical fully defined machine).
> > It's pretty shallow conversion instead of currently used trivial
> > DEFINE_MACHINE() macro. It adds extra 60LOC of boilerplate code
> > of full machine definition.
> > The patch on top will use PCCE500MachineState to keep track of
> > platform_bus device and add E500Plate specific machine class
> > to use HOTPLUG_HANDLER for explicitly initializing dynamic
> > sysbus devices at the time they are added instead of delaying
> > it to machine done time by platform_bus_init_notify() which is
> > being removed.
> > 1) <address@hidden>
> > Signed-off-by: Igor Mammedov <address@hidden>
> > Suggested-by: David Gibson <address@hidden>
> As noted elsewhere, I've already merged this into my ppc-for-2.13
> tree. However, don't let that stop you from posting and/or queueing
> it elsewhere. Whoever ends up merging first once 2.13 opens, it
> should be easy to resolve.
Yep, that's been intention, i.e. have whole series on list so
reader won't have to hunt for queued dependencies in different trees.
After all it's trivial to fix merge conflict when path is merged
in several trees.