qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH] ppc: Include vga cirrus card into the compiling p


From: Sebastian Bauer
Subject: Re: [Qemu-ppc] [PATCH] ppc: Include vga cirrus card into the compiling process
Date: Tue, 19 Jun 2018 12:46:01 +0200
User-agent: Roundcube Webmail/1.3.6

Am 2018-06-19 12:23, schrieb BALATON Zoltan:
On Tue, 19 Jun 2018, David Gibson wrote:
Ok.  However, your patch doesn't apply against the ppc-for-3.0 tree.
It looks like you've made it against a tree including some of BALATON
Zoltan's proposed but not yet merged patches.
I've sent those patches as well. But if this also works with pseries
maybe it does not have to be in the For sam460ex part of the config
but could be on it's own with a comment saying that multiple machines
can use it.

In my opinion, it should be added to pci.mak (and removed from all present configs that include pci.mak). There is also CONFIG_VGA_PCI there, a bunch of network cards and other stuff. The Cirrus VGA is just another PCI card that one could plug into any systems that has a PCI(e) bus, also on physical hardware (whether it is supported by which guests is a different question).

However, I wanted to be conservative with my change so I added it only to the 32 bit PPC branch, because this is the platform that I can easily test. Does anybody know why CONFIG_VGA_CIRRUS is selectively enabled for PCI-based systems? What would speak against adding it to pci.mak?

Bye
Sebastian



reply via email to

[Prev in Thread] Current Thread [Next in Thread]