[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 0/5] rework the ICS classes inheritance tree
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-ppc] [PATCH v2 0/5] rework the ICS classes inheritance tree |
Date: |
Tue, 26 Jun 2018 18:37:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 |
On 06/26/2018 03:27 PM, Greg Kurz wrote:
> On Mon, 25 Jun 2018 11:17:13 +0200
> Cédric Le Goater <address@hidden> wrote:
>
>> Hello,
>>
>
> Hello,
>
> Sorry I didn't manage to look at this before it got merged :)
>
>> It makes the class hierarchy much cleaner and removes duplicated
>> code. As we are touching the location of the objects states, migration
>> compatibility was checked and the following tests were performed under
>> KVM :
>>
>> qemu-3.0 (pseries-3.0) -> qemu-3.0 (pseries-3.0) OK
>> qemu-3.0 (pseries-2.12) -> qemu-2.12 (pseries-2.12) OK
>> qemu-3.0 (pseries-2.11) -> qemu-2.11 (pseries-2.11) OK
>> qemu-3.0 (pseries-2.10) -> qemu-2.10 (pseries-2.10) OK
>> qemu-3.0 (pseries-2.9) -> qemu-2.9 (pseries-2.9) OK
>> qemu-3.0 (pseries-2.8) -> qemu-2.8 (pseries-2.8) OK
>> qemu-3.0 (pseries-2.7) -> qemu-2.7 (pseries-2.7) FAIL
>
> What's the failure ?
qemu-system-ppc64: error while loading state for instance 0x0 of device 'cpu'
qemu-system-ppc64: load of migration failed: Invalid argument
and to be more precise :
qemu-3.0 (pseries-2.7) -> qemu-2.7 (pseries-2.7) FAIL
qemu-2.12 (pseries-2.7) -> qemu-2.7 (pseries-2.7) FAIL
qemu-2.11 (pseries-2.7) -> qemu-2.7 (pseries-2.7) FAIL
qemu-2.10 (pseries-2.7) -> qemu-2.7 (pseries-2.7) FAIL
qemu-2.9 (pseries-2.7) -> qemu-2.7 (pseries-2.7) FAIL
qemu-2.8 (pseries-2.7) -> qemu-2.7 (pseries-2.7) FAIL
qemu-2.7 (pseries-2.7) -> qemu-2.7 (pseries-2.7) OK
So it has been a while.
C.
>
>>
>> and back :
>>
>> qemu-3.0 (pseries-3.0) <- qemu-3.0 (pseries-3.0) OK
>> qemu-3.0 (pseries-2.12) <- qemu-2.12 (pseries-2.12) OK
>> qemu-3.0 (pseries-2.11) <- qemu-2.11 (pseries-2.11) OK
>> qemu-3.0 (pseries-2.10) <- qemu-2.10 (pseries-2.10) OK
>> qemu-3.0 (pseries-2.9) <- qemu-2.9 (pseries-2.9) OK
>> qemu-3.0 (pseries-2.8) <- qemu-2.8 (pseries-2.8) OK
>> qemu-3.0 (pseries-2.7) <- qemu-2.7 (pseries-2.7) OK
>>
>> under TCG, same scenarios were run but up to 2.10 only, in which case
>> the migration fails for other reasons.
>>
>> I wouldn't mind some extra cross checking from someone else.
>>
>> Thanks,
>>
>> C.
>>
>> Changes since v2:
>>
>> - split the patch in smaller units. The migration tests were not
>> rerun because the code is very much the same. make check was run on
>> each patch.
>>
>>
>> Cédric Le Goater (5):
>> ppc/xics: introduce a parent_realize in ICSStateClass
>> ppc/xics: move the instance_init handler under the ics-base class
>> ppx/xics: introduce a parent_reset in ICSStateClass
>> ppc/xics: move the vmstate structures under the ics-base class
>> ppc/xics: rework the ICS classes inheritance tree
>>
>> include/hw/ppc/xics.h | 4 +-
>> hw/intc/xics.c | 164
>> ++++++++++++++++++++++++++++----------------------
>> hw/intc/xics_kvm.c | 46 +++++++-------
>> hw/ppc/spapr.c | 2 +-
>> 4 files changed, 121 insertions(+), 95 deletions(-)
>>
>
- Re: [Qemu-ppc] [PATCH v2 1/5] ppc/xics: introduce a parent_realize in ICSStateClass, (continued)
- [Qemu-ppc] [PATCH v2 2/5] ppc/xics: move the instance_init handler under the ics-base class, Cédric Le Goater, 2018/06/25
- [Qemu-ppc] [PATCH v2 3/5] ppx/xics: introduce a parent_reset in ICSStateClass, Cédric Le Goater, 2018/06/25
- [Qemu-ppc] [PATCH v2 4/5] ppc/xics: move the vmstate structures under the ics-base class, Cédric Le Goater, 2018/06/25
- [Qemu-ppc] [PATCH v2 5/5] ppc/xics: rework the ICS classes inheritance tree, Cédric Le Goater, 2018/06/25
- Re: [Qemu-ppc] [PATCH v2 0/5] rework the ICS classes inheritance tree, Greg Kurz, 2018/06/26
- Re: [Qemu-ppc] [PATCH v2 0/5] rework the ICS classes inheritance tree,
Cédric Le Goater <=