[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH] sam460ex: Add comment explaining ignored errors f

From: Paolo Bonzini
Subject: Re: [Qemu-ppc] [PATCH] sam460ex: Add comment explaining ignored errors from fdt operations
Date: Thu, 5 Jul 2018 16:06:28 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 05/07/2018 15:51, Guenter Roeck wrote:
> +        /* Failure to set serial port clocks is not fatal, so just ignore
> +         * errors when trying to do so.
> +         */
> +        (void)fdt_setprop_cell(fdt, offset, "clock-frequency", UART_FREQ);
>          offset = fdt_node_offset_by_compatible(fdt, offset, "ns16550");

Ok, but why would it even fail?  Maybe it's not this case, but even if
it's not fatal for the OS, generating different device trees silently
seems like a recipe for Heisenbugs.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]