[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH] vga: make stdvga the global default

From: Mark Cave-Ayland
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH] vga: make stdvga the global default
Date: Fri, 6 Jul 2018 08:54:09 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 06/07/18 08:14, Gerd Hoffmann wrote:

On Thu, Jul 05, 2018 at 05:24:09PM +0100, Mark Cave-Ayland wrote:
On 05/07/18 14:12, Eduardo Habkost wrote:

I also checked the code, default values are used also for other fields in
that struct (e.g., default_cpus). If default values are considered fragile,
they must be changed as well in the middle term. However, given a solid
documentation (which is currently missing for these fields) I still think
that default values are acceptable.

Note that there seems also be the possibility to set != NULL default values
in the machine_class_init() function.

I don't mind if the default value is defined at
machine_class_init() or main().  What bothers me is a default
value that depends on vga_interface_available(), because it can
be easily broken by a build config change (as demonstrated by the
bug fixed by this patch).

I've already sent David a for-3.0 patch to set stdvga for the PPC Mac
machines, but should I also do the same for PReP too?

Makes sense, yes.

Okay, done. This should ensure that the PPC Mac/PReP machines will always work regardless of what the outcome of your other patchset is.

Is it also worth explicitly adding this for sun4u? And what about
non-ISA/PCI cards such as sun4m's TCX/CG3?

Hmm, sparc has its own mechanism to use tcx as default (IIRC you get tcx
unless -vga cg3 is specified).  Should be possible to switch this over
to use the MachineClass field instead.

Thanks for the pointers - I'll have a look at this again when the 3.1 development cycle opens.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]