[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 2/2] tpm_spapr: Support suspend an

From: Eric Blake
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 2/2] tpm_spapr: Support suspend and resume
Date: Thu, 26 Jul 2018 09:01:12 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 07/26/2018 12:31 AM, David Gibson wrote:

On Tue, Dec 12, 2017 at 03:44:03PM -0500, Stefan Berger wrote:
Signed-off-by: Stefan Berger <address@hidden>
  hw/tpm/tpm_spapr.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++----
  1 file changed, 57 insertions(+), 4 deletions(-)

diff --git a/hw/tpm/tpm_spapr.c b/hw/tpm/tpm_spapr.c
index ef5e62d..0b8a424 100644
--- a/hw/tpm/tpm_spapr.c
+++ b/hw/tpm/tpm_spapr.c
@@ -248,9 +248,8 @@ static int tpm_spapr_do_crq(struct VIOsPAPRDevice *dev, 
uint8_t *crq_data)
      return H_SUCCESS;
-static void tpm_spapr_request_completed(TPMIf *ti)
+static void _tpm_spapr_request_completed(SPAPRvTPMState *s)

Don't start identifiers with _, please, they're reserved by the
standard library.

Technically, is is _[_A-Z] reserved by the implementation; use of _[a-z] is just fine for file-scoped identifiers, like this one. But it is still unusual in our codebase, and best avoided.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]