[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH] sam460ex: Fix PCI interrupt connecti

From: BALATON Zoltan
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH] sam460ex: Fix PCI interrupt connections
Date: Tue, 31 Jul 2018 11:50:02 +0200 (CEST)
User-agent: Alpine 2.21 (BSF 202 2017-01-01)

On Tue, 31 Jul 2018, Sebastian Bauer wrote:
There is also the possibility to make the special (num-irqs == 1) the common case, as the Sam460ex platform is the only user of this bus so far (and probably stays the only one). I'm not sure if it is worth all the hassle.

I'd vote for this as I've said before. This seems to be the simplest solution so just change ppc440_pcix to have one irq instead of 4.

Also note that the entire ppc440_pcix.c source file seems to be created for the sam board. I have no idea why that mapping function based on slots was chosen in the first place so I kept it. I would also be fine to remove that, which would simplify things a lot.

It may come from other similar devices I've based the implementation on (ppc4xx_pci and ppce500) so no particular reason as I had no info on the real hardware and since I haven't tried multiple PCI cards it was just left there. You can remove it, I don't have anything that says it should be there, definitely not needed for sam460ex.

Let me know how to proceed.

Will you send an updated patch or should I take and modify your latest one to help with this?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]