[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PULL 0/2] ppc-for-3.0 queue 20180801

From: David Gibson
Subject: Re: [Qemu-ppc] [PULL 0/2] ppc-for-3.0 queue 20180801
Date: Fri, 3 Aug 2018 00:07:44 +1000
User-agent: Mutt/1.10.1 (2018-07-13)

On Thu, Aug 02, 2018 at 10:16:32AM +0100, Peter Maydell wrote:
> On 2 August 2018 at 08:08, David Gibson <address@hidden> wrote:
> > The macio fix, however, *is* a regression from 2.12.  Whether it's
> > severe enough to warrant another -rc, I'm not sure.  It is a bad
> > pointer access which is, well, bad.  It doesn't seem to bite
> > obviously, needing valgrind to pick it up, but possibly that's just
> > luck.
> I thought those introspection-bugs like the macio ones weren't
> regressions ?

Well, I ran Thomas's testcase on master and it generates several
valgrind warnings, which don't appear on either 2.12 or master+the

> Certainly the devices have been leaking a refcount
> in their init methods for a long time. I don't view these as
> very important bugs, though, as they only manifest if you
> try to introspect fixed-always-present device/SoC objects,
> which in practice I don't think anybody does except as
> part of "test every device via introspection" test cases.
> thanks
> -- PMM

David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]