[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/3] hw/ppc/prep: Remove ifdeffed-out

From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/3] hw/ppc/prep: Remove ifdeffed-out stub of XCSR code
Date: Thu, 2 Aug 2018 13:14:10 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 08/02/2018 12:54 PM, Peter Maydell wrote:
> On 2 August 2018 at 16:45, Philippe Mathieu-Daudé <address@hidden> wrote:
>> While not directly use the harmless UnimplementedDevice?
>>        create_unimplemented_device("ppc-xcsr", 0xfeff0000, 0x1000);
> I preferred not to change the current behaviour for this
> API conversion. If the PPC/prep maintainers would like to
> use unimplemented-device they can easily do so as a a
> different patch...

Now I remember there is a behaviour change in using this device:
currently an access to this address space triggers
using UnimplementedDevice doesn't.

So better to do this change in a different patch indeed :)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]