[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 1/2] hw/ppc: on 40p machine, change default firmwa

From: Hervé Poussineau
Subject: Re: [Qemu-ppc] [PATCH 1/2] hw/ppc: on 40p machine, change default firmware to OpenBIOS
Date: Fri, 10 Aug 2018 07:38:32 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

Le 10/08/2018 à 03:04, David Gibson a écrit :
On Thu, Aug 09, 2018 at 10:40:09PM +0200, Hervé Poussineau wrote:
OpenBIOS gained 40p support in 5b20e4cacecb62fb2bdc6867c11d44cddd77c4ff
Use it, instead of relying on the presence of a proprietary

Uh..  openhackware might be, well, a hack, but I don't think it's
propietary.  Replacing it with openbios might well be a good idea, but
we want an accurrate reason for doing so.

Oops, you're right. That's what happens when you try to change/expand
your commit messages just before sending the patch. I will resend.

Signed-off-by: Hervé Poussineau <address@hidden>
  hw/ppc/prep.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
index 3401570d98..1558855247 100644
--- a/hw/ppc/prep.c
+++ b/hw/ppc/prep.c
@@ -736,7 +736,7 @@ static void ibm_40p_init(MachineState *machine)
      /* PCI host */
      dev = qdev_create(NULL, "raven-pcihost");
      if (!bios_name) {
-        bios_name = BIOS_FILENAME;
+        bios_name = "openbios-ppc";
      qdev_prop_set_string(dev, "bios-name", bios_name);
      qdev_prop_set_uint32(dev, "elf-machine", PPC_ELF_MACHINE);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]