[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 4/8] ppc4xx: Use ram_addr_t in ppc4xx_sdram_adjust
Re: [Qemu-ppc] [PATCH 4/8] ppc4xx: Use ram_addr_t in ppc4xx_sdram_adjust()
Fri, 4 Jan 2019 16:17:30 +1100
On Thu, Jan 03, 2019 at 03:03:20PM +0100, BALATON Zoltan wrote:
> On Wed, 2 Jan 2019, David Gibson wrote:
> > On Wed, Jan 02, 2019 at 03:06:38AM +0100, BALATON Zoltan wrote:
> > > To avoid overflow if larger values are added later use ram_addr_t for
> > > the sdram_bank_sizes parameter to match ram_size to which it is
> > > compared.
> > So, technically I think these should be 'hwaddr' (which represents a
> > guest physical address) rather tham ram_addr_t which
> > represents... something subtley different I've never properly
> > understood.
> I don't understand the difference either but ram_size in MachineState where
> this value comes from is ram_addr_t now so I've left is for now. If someone
> knows which type should this be can change it in another patch
Ok, fair enough.
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
Description: PGP signature
[Qemu-ppc] [PATCH 8/8] MAINTAINERS: Add more files to sam460ex, BALATON Zoltan, 2019/01/01
[Qemu-ppc] [PATCH 3/8] ppc4xx: Disable debug logging by default, BALATON Zoltan, 2019/01/01
[Qemu-ppc] [PATCH 6/8] ppc4xx: Pass array index to function instead of pointer into the array, BALATON Zoltan, 2019/01/01
[Qemu-ppc] [PATCH 7/8] sam460ex: Fix support for memory larger than 1GB, BALATON Zoltan, 2019/01/01
[Qemu-ppc] [PATCH 2/8] sam460ex: Clean up SPD EEPROM creation, BALATON Zoltan, 2019/01/01