[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 07/13] qdev: pass an Object * to q

From: Halil Pasic
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 07/13] qdev: pass an Object * to qbus_set_hotplug_handler()
Date: Mon, 14 Jan 2019 20:36:13 +0100

On Fri, 11 Jan 2019 22:02:50 +0100
Greg Kurz <address@hidden> wrote:

> From: Michael Roth <address@hidden>
> Certain devices types, like memory/CPU, are now being handled using a
> hotplug interface provided by a top-level MachineClass. Hotpluggable
> host bridges are another such device where it makes sense to use a
> machine-level hotplug handler. However, unlike those devices,
> host-bridges have a parent bus (the main system bus), and devices with
> a parent bus use a different mechanism for registering their hotplug
> handlers: qbus_set_hotplug_handler(). This interface currently expects
> a handler to be a subclass of DeviceClass, but this is not the case
> for MachineClass, which derives directly from ObjectClass.
> Internally, the interface only requires an ObjectClass, so expose that
> in qbus_set_hotplug_handler().
> Cc: Michael S. Tsirkin <address@hidden>
> Cc: Eduardo Habkost <address@hidden>
> Signed-off-by: Michael Roth <address@hidden>
> Signed-off-by: Greg Kurz <address@hidden>
> Reviewed-by: David Gibson <address@hidden>

Acked-by: Halil Pasic <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]