[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 05/10] xics: Drop the KVM ICP class
|
From: |
Cédric Le Goater |
|
Subject: |
Re: [Qemu-ppc] [PATCH 05/10] xics: Drop the KVM ICP class |
|
Date: |
Mon, 18 Feb 2019 08:08:37 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/18/19 12:37 AM, David Gibson wrote:
> On Fri, Feb 15, 2019 at 02:35:03PM +0100, Cédric Le Goater wrote:
>> On 2/15/19 2:18 PM, Greg Kurz wrote:
>>> On Fri, 15 Feb 2019 13:55:53 +0100
>>> Cédric Le Goater <address@hidden> wrote:
>>>
>>>> On 2/15/19 12:40 PM, Greg Kurz wrote:
>>>>> The KVM ICP class isn't used anymore. Drop it.
>>>>
>>>> Isn't migration complaining ? If not,
>>>>
>>>
>>> Hm.. no, but why would migration complain ?
>>
>> You are changing the type name of the object being transferred:
>>
>> "icp-kcm" -> "icp"
>
> It's a little more complex than that. The way migration works, the
> state associated with the base class is transferred under the name
> "icp" and the state associated with the derived class is transferred
> under the name "icp-kvm".
>
>> Isn't that an issue ?
>
> It would be.. except that there is no extra state in the derived
> class, which is why we got away with this not-very-good solution at
> all in the first place.
Ah good. Another reason to get rid of the sub-class.
C.
- Re: [Qemu-ppc] [PATCH 03/10] xics: Handle KVM ICP realize from the common code, (continued)
[Qemu-ppc] [PATCH 06/10] xics: Explicitely call KVM ICS methods from the common code, Greg Kurz, 2019/02/15
[Qemu-ppc] [PATCH 07/10] xics: Handle KVM ICS reset from the "simple" ICS code, Greg Kurz, 2019/02/15
[Qemu-ppc] [PATCH 08/10] xics: Handle KVM interrupt presentation from "simple" ICS code, Greg Kurz, 2019/02/15