qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH v3 07/25] gdbstub: Let put_buffer() use size_t


From: Marc-André Lureau
Subject: Re: [Qemu-ppc] [PATCH v3 07/25] gdbstub: Let put_buffer() use size_t
Date: Wed, 20 Feb 2019 12:02:58 +0100

On Wed, Feb 20, 2019 at 2:04 AM Philippe Mathieu-Daudé
<address@hidden> wrote:
>
> All callers provide a size_t argument, we can safely use size_t
> for this function.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

Reviewed-by: Marc-André Lureau <address@hidden>

> ---
>  gdbstub.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 69340d7cd1..860e9bb7c7 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -475,10 +475,10 @@ static int gdb_continue_partial(GDBState *s, char 
> *newstates)
>      return res;
>  }
>
> -static void put_buffer(GDBState *s, const uint8_t *buf, int len)
> +static void put_buffer(GDBState *s, const uint8_t *buf, size_t len)
>  {
>  #ifdef CONFIG_USER_ONLY
> -    int ret;
> +    ssize_t ret;
>
>      while (len > 0) {
>          ret = send(s->fd, buf, len, 0);
> --
> 2.20.1
>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]