Re: [Qemu-ppc] [RFC PATCH v4 2/5] kvm-all: Introduce kvm_set_singlestep

[Fabiano Rosas]

David Gibson <address@hidden> writes:

>> +/* Whether the KVM_SET_GUEST_DEBUG ioctl supports single stepping */
>> +int kvm_has_guestdbg_singlestep(void)
>> +{
>> +    /* return kvm_check_extension(kvm_state, KVM_CAP_GUEST_DEBUG_SSTEP); */
>
> I don't see a KVM_CAP_GUEST_DEBUG_SSTEP in either the qemu or kernel
> trees.  Where does that come from?
>

I realized that this will cause a regression for the other architectures
(and even PPC-PR) that already have the feature when we run QEMU on
older kernels without this capability.

I am becoming inclined to rely on kvmppc_is_pr. Do you see another way
around this?