qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [RFC for-4.1 10/25] target/ppc: Style fixes for helper_re


From: Cédric Le Goater
Subject: Re: [Qemu-ppc] [RFC for-4.1 10/25] target/ppc: Style fixes for helper_regs.h
Date: Mon, 25 Mar 2019 07:33:30 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 3/22/19 1:15 AM, David Gibson wrote:
> Signed-off-by: David Gibson <address@hidden>


Reviewed-by: Cédric Le Goater <address@hidden>

Thanks,

C.

> ---
>  target/ppc/helper_regs.h | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/target/ppc/helper_regs.h b/target/ppc/helper_regs.h
> index a2205e1044..8397819dee 100644
> --- a/target/ppc/helper_regs.h
> +++ b/target/ppc/helper_regs.h
> @@ -44,10 +44,11 @@ static inline void hreg_swap_gpr_tgpr(CPUPPCState *env)
>  
>  static inline void hreg_compute_mem_idx(CPUPPCState *env)
>  {
> -    /* This is our encoding for server processors. The architecture
> +    /*
> +     * This is our encoding for server processors. The architecture
>       * specifies that there is no such thing as userspace with
> -     * translation off, however it appears that MacOS does it and
> -     * some 32-bit CPUs support it. Weird...
> +     * translation off, however it appears that MacOS does it and some
> +     * 32-bit CPUs support it. Weird...
>       *
>       *   0 = Guest User space virtual mode
>       *   1 = Guest Kernel space virtual mode
> @@ -143,7 +144,8 @@ static inline int hreg_store_msr(CPUPPCState *env, 
> target_ulong value,
>          /* Change the exception prefix on PowerPC 601 */
>          env->excp_prefix = ((value >> MSR_EP) & 1) * 0xFFF00000;
>      }
> -    /* If PR=1 then EE, IR and DR must be 1
> +    /*
> +     * If PR=1 then EE, IR and DR must be 1
>       *
>       * Note: We only enforce this on 64-bit server processors.
>       * It appears that:
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]