[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 04/15] target/ppc: introduce separ
From: |
Richard Henderson |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 04/15] target/ppc: introduce separate VSX_CMP macro for xvcmp* instructions |
Date: |
Wed, 12 Jun 2019 12:59:12 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/2/19 4:08 AM, Mark Cave-Ayland wrote:
> Rather than perform the VSR register decoding within the helper itself,
> introduce a new VSX_CMP macro which performs the decode based upon xT, xA
> and xB at translation time.
>
> Subsequent commits will make the same changes for other instructions however
> the xvcmp* instructions are different in that they return a set of flags to be
> optionally written back to the crf[6] register. Move this logic from the
> helper function to the generator function, along with the float_status update.
>
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> ---
> target/ppc/fpu_helper.c | 15 +++++-------
> target/ppc/helper.h | 20 +++++++++------
> target/ppc/translate/vsx-impl.inc.c | 49
> +++++++++++++++++++++++++++++++------
> 3 files changed, 59 insertions(+), 25 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
[Qemu-ppc] [PATCH v2 03/15] target/ppc: remove getVSR()/putVSR() from int_helper.c, Mark Cave-Ayland, 2019/06/02
[Qemu-ppc] [PATCH v2 02/15] target/ppc: remove getVSR()/putVSR() from mem_helper.c, Mark Cave-Ayland, 2019/06/02
[Qemu-ppc] [PATCH v2 09/15] target/ppc: introduce GEN_VSX_HELPER_X1 macro to fpu_helper.c, Mark Cave-Ayland, 2019/06/02
[Qemu-ppc] [PATCH v2 08/15] target/ppc: introduce GEN_VSX_HELPER_X2_AB macro to fpu_helper.c, Mark Cave-Ayland, 2019/06/02