Re: [Qemu-ppc] [Qemu-devel] [PATCH v5 11/15] memory: Single byte swap along the I/O path

[Paolo Bonzini]

On 26/07/19 08:47, address@hidden wrote:
> +        op = SIZE_MEMOP(size);
> +        if (need_bswap(big_endian)) {
> +            op ^= MO_BSWAP;
> +        }

And this has the same issue as the first version.  It should be

        op = SIZE_MEMOP(size) | (big_endian ? MO_BE : MO_LE);

and everything should work.  If it doesn't (and indeed it doesn't :)) it
means you have bugs somewhere else.

Paolo