[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH v6 00/26] Invert Endian bit in SPARCv

From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH v6 00/26] Invert Endian bit in SPARCv9 MMU TTE
Date: Wed, 7 Aug 2019 14:54:40 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0

On 8/7/19 2:41 PM, address@hidden wrote:
> On 8/7/19 8:37 PM, Philippe Mathieu-Daudé wrote:
>> I'm confused I think I already reviewed various patches of your previous
> ​> series but don't see my Reviewed-by tags.​>
> Apologies Philippe! I am the confused one here =/
> Will append.
> Thank you very much for the reviews and qemu-devel newbie tips so far. I
> have felt very welcome.

Well for a newbie you did an impressive series!

The 'Reviewed-by' or 'Tested-by' tags help the maintainers to process

Since reviewing a series is time-consuming, if you iterate over a series
without changing some patchs, you should collect and amend the tags the
reviewers gave you, this way it helps them keep track of patches
reviewed and patches waiting for review.

In my case I find it very confuse when I look at a patch I already gave
my R-b tag and the tag is not here, I re-review the patch looking for

Often a reviewer asks for easy changes, and uses "with this changes:
R-b". If you addresses his comments you can then add his tag in the next

If you split a reviewed patch in various, it is also OK to keep the tags
in all the splitted patches.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]