[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 02/33] add temporary device_legacy

From: Damien Hedde
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 02/33] add temporary device_legacy_reset function to replace device_reset
Date: Fri, 9 Aug 2019 11:20:44 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 8/7/19 4:27 PM, Peter Maydell wrote:
> On Mon, 29 Jul 2019 at 15:58, Damien Hedde <address@hidden> wrote:
>> Provide a temporary function doing what device_reset does to do the
>> transition with Resettable API which will trigger a prototype change
>> of device_reset.
> The other point here is that device_legacy_reset() resets
> only that device, not any of its qbus children, right?
> So the new function which we eventually replace the callsites
> with also has different semantics, which is why we do the
> changes one by one in patches 10-28.

Yes, for device_reset there is a change of scope.

> So you could add:
> The new resettable API function also has different semantics
> (resetting child buses as well as the specified device).
> Subsequent commits will make the changeover for each callsite
> individually; once that is complete device_legacy_reset() will be
> removed.


>> Signed-off-by: Damien Hedde <address@hidden>
> I agree with David that patch 3 could be squashed into this one.


> If you do that and tweak the commit message you can have
> Reviewed-by: Peter Maydell <address@hidden>
> thanks
> -- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]