[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 14/33] serial-mm: add "regshift" property

From: Peter Maydell
Subject: Re: [PATCH v3 14/33] serial-mm: add "regshift" property
Date: Mon, 18 Nov 2019 14:54:34 +0000

On Wed, 23 Oct 2019 at 18:34, Marc-André Lureau
<address@hidden> wrote:
> And a property and rename "it_shift" field to "regshift", as it seems
> to be more popular (and I don't know what "it" stands for).
> Signed-off-by: Marc-André Lureau <address@hidden>

I have no idea what it_shift means either (I had a look in the
git history but it seems to have been added with that name
very early on when the commit logs were generally not very
informative); 'regshift' sounds good to me too.

> +static Property serial_mm_properties[] = {
> +    DEFINE_PROP_UINT8("regshift", SerialMM, regshift, 0),

This could use a comment describing what the property does.


Reviewed-by: Peter Maydell <address@hidden>

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]