[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/3] mem: move nvdimm_device_list to utilities

From: Shivaprasad G Bhat
Subject: Re: [PATCH v3 1/3] mem: move nvdimm_device_list to utilities
Date: Wed, 20 Nov 2019 13:31:34 +0530
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

Hi Igor,

On 11/19/2019 12:43 PM, Igor Mammedov wrote:
On Mon, 14 Oct 2019 13:37:37 -0500
Shivaprasad G Bhat <address@hidden> wrote:

nvdimm_device_list is required for parsing the list for devices
in subsequent patches. Move it to common utility area.

Signed-off-by: Shivaprasad G Bhat <address@hidden>
  hw/acpi/nvdimm.c            |   28 +---------------------------
  include/qemu/nvdimm-utils.h |    7 +++++++
  util/Makefile.objs          |    1 +
  util/nvdimm-utils.c         |   29 +++++++++++++++++++++++++++++
instead of creating new file, why not to move it to existing hw/mem/nvdimm.c?

That would break the build for mips-softmmu. The mips has CONFIG_ACPI_NVDIMM=y and not CONFIG_NVDIMM. So, the build would break failing to fetch the definition from

I have the patch here from v2 of the series,



reply via email to

[Prev in Thread] Current Thread [Next in Thread]