[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] pnv/psi: Consolidate some duplicated code in pnv_psi_rea
Cédric Le Goater
Re: [PATCH 2/2] pnv/psi: Consolidate some duplicated code in pnv_psi_realize()
Wed, 8 Jan 2020 14:20:45 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2
On 1/8/20 11:58 AM, Greg Kurz wrote:
> On Wed, 8 Jan 2020 11:54:53 +1100
> David Gibson <address@hidden> wrote:
>> On Tue, Jan 07, 2020 at 07:32:03PM +0100, Philippe Mathieu-Daudé wrote:
>>> Hi Greg,
>>> On 1/7/20 5:32 PM, Greg Kurz wrote:
>>>> The proper way to do that would be to use
>>>> but defining a Pnv8PsiClass and a Pnv9PsiClass types with a parent_realize
>>>> pointer adds a fair amount of code. Calling pnv_psi_realize() explicitely
>>>> is fine for now.
>>>> This should probably be achieved with a device realize hook in the
>>>> PSI base class and device_class_set_parent_realize() in the children
> I realize that this last paragraph is a leftover. First paragraph already
> mentions device_class_set_parent_realize() as being the "proper way".
> Can you remove it in your tree ? No big deal if you can't.
>>> Can you add a note explaining why the POWER10 PSI doesn't need it?
>> For now, POWER10 uses the Pnv9PsiClass, I believe, so the question
>> doesn't arise.
> This is correct and also a bit confusing, as proves Philippe's remark.
> Maybe we should come up with a PnvXivePsiClass and specialize it for
> POWER9 and POWER10.
Yes. I think this is the way to go.
P8 has a PSI device using the XICS interrupt interface. P9 and P10 use
the XIVE interface.