[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/acceptance: Add boot tests for some of the QEMU advent
Re: [PATCH] tests/acceptance: Add boot tests for some of the QEMU advent calendar images
Sat, 25 Jan 2020 19:38:23 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2
On 1/25/20 5:43 PM, Thomas Huth wrote:
> On 24/01/2020 22.28, Wainer dos Santos Moschetta wrote:
>> On 1/24/20 3:03 PM, Thomas Huth wrote:
>>> The 2018 edition of the QEMU advent calendar 2018 featured Linux images
>>> for various non-x86 machines. We can use them for a boot tests in our
>>> acceptance test suite.
>>> Let's also make sure that we build the corresponding machines in Travis,
>>> and while we're there, drop the superfluous --python parameter (python3
>>> is now the only supported version anyway).
I'd rather see this change as another commit.
>> Yes, please, removal of --python was in my wish list.
>>> Signed-off-by: Thomas Huth <address@hidden>
>>> .travis.yml | 2 +-
>>> tests/acceptance/boot_linux_console.py | 96 ++++++++++++++++++++++++++
>>> 2 files changed, 97 insertions(+), 1 deletion(-)
>>> diff --git a/.travis.yml b/.travis.yml
>>> index 6c1038a0f1..73ca12c921 100644
>>> --- a/.travis.yml
>>> +++ b/.travis.yml
>>> @@ -268,7 +268,7 @@ matrix:
>>> # Acceptance (Functional) tests
>>> - env:
>>> - - CONFIG="--python=/usr/bin/python3
>>> + -
>> Perhaps use MAIN_SOFTMMU_TARGETS in only append the other targets, like:
> Not sure ... while it is a nice way to shorten the line here, it adds a
> dependecy to that variable ... and MAIN_SOFTMMU_TARGETS has been changed
> a couple of times during the course of time, so we might risk to lose
> some testing coverage here in case someone removes a target from
> MAIN_SOFTMMU_TARGETS but forgets to add it here again...? I think we
> should better use the explicit list here instead.
Maybe related: "Split enterprise vs. hobbyist acceptance test job"
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Re: [PATCH] tests/acceptance: Add boot tests for some of the QEMU advent calendar images, Wainer dos Santos Moschetta, 2020/01/27
Re: [PATCH] tests/acceptance: Add boot tests for some of the QEMU advent calendar images, Wainer dos Santos Moschetta, 2020/01/30
Re: [PATCH] tests/acceptance: Add boot tests for some of the QEMU advent calendar images, Philippe Mathieu-Daudé, 2020/01/30