[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] qtest: Fix rtas dependencies
|
From: |
Laurent Vivier |
|
Subject: |
Re: [PATCH 1/2] qtest: Fix rtas dependencies |
|
Date: |
Wed, 5 Feb 2020 21:49:04 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 05/02/2020 21:46, Thomas Huth wrote:
> On 05/02/2020 21.41, Laurent Vivier wrote:
>> qtest "rtas" command is only available with pseries not all ppc64 targets,
>> so if I try to compile only powernv machine, the build fails with:
>>
>> /usr/bin/ld: qtest.o: in function `qtest_process_command':
>> .../qtest.c:645: undefined reference to `qtest_rtas_call'
>>
>> We fix this by enabling rtas command only with pseries machine.
>>
>> Fixes: eeddd59f5962 ("tests: add RTAS command in the protocol")
>
> Well, at that point in time CONFIG_PSERIES was not available yet ... so
> not sure if the "Fixes:" really makes sense here...
You are right, but I think it's interesting to show the dependency we
have between patches.
> But apart from that:
> Reviewed-by: Thomas Huth <address@hidden>
>
Thank you!
Laurent