Re: [PATCH] tests/acceptance/ppc_prep_40p: Do not run NetBSD test by default

[Wainer dos Santos Moschetta]

On 2/11/20 11:19 AM, Philippe Mathieu-Daudé wrote:
> The ftp.netbsd.org server is slow and downloading the NetBSD ISO
> takes too long. Do not include this test in the default suite.
>
> Similarly to commit 471c97a69b:
>
>    Currently the Avocado framework does not distinct the time spent
>    downloading assets vs. the time spent running a test. With big
>    assets (like a full VM image) the tests likely fail.
>
>    This is a limitation known by the Avocado team.
>    Until this issue get fixed, do not run this tests automatically.
>
>    Tests can still be run setting the AVOCADO_TIMEOUT_EXPECTED
>    environment variable.
>
> Reported-by: Alex Bennée <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>   tests/acceptance/ppc_prep_40p.py | 1 +
>   1 file changed, 1 insertion(+)


LGTM.

Reviewed-by: Wainer dos Santos Moschetta <address@hidden>


> diff --git a/tests/acceptance/ppc_prep_40p.py b/tests/acceptance/ppc_prep_40p.py
> index b27572f212..efe06037ba 100644
> --- a/tests/acceptance/ppc_prep_40p.py
> +++ b/tests/acceptance/ppc_prep_40p.py
> @@ -61,6 +61,7 @@ def test_openbios_192m(self):
>           wait_for_console_pattern(self, '>> CPU type PowerPC,604')
>   
>       @skipIf(os.getenv('CONTINUOUS_INTEGRATION'), 'Running on Travis-CI')
> +    @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
>       def test_openbios_and_netbsd(self):
>           """
>           :avocado: tags=arch:ppc